Skip to content

Rewrites test for clear handler cache. - #195

Merged
bajtos merged 1 commit into
strongloop:masterfrom
globocom:fix-clear-handler-cache-test
Feb 21, 2014
Merged

Rewrites test for clear handler cache.#195
bajtos merged 1 commit into
strongloop:masterfrom
globocom:fix-clear-handler-cache-test

Conversation

@gcirne

@gcirne gcirne commented Feb 19, 2014

Copy link
Copy Markdown
Contributor

See #193.

@slnode

slnode commented Feb 19, 2014

Copy link
Copy Markdown

Test FAILed. To trigger a build add comment - ".test\W+please"
Refer to this link for build results: http://ci.strongloop.com/job/loopback/963/

bajtos
bajtos reviewed Feb 20, 2014
View reviewed changes
Comment thread test/app.test.js Outdated

@bajtos bajtos Feb 20, 2014

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the test name too. How about it('updates REST API when a new model is added')?

@gcirne

gcirne commented Feb 20, 2014

Copy link
Copy Markdown
Contributor Author

Done!

@slnode

slnode commented Feb 20, 2014

Copy link
Copy Markdown

Test FAILed. To trigger a build add comment - ".test\W+please"
Refer to this link for build results: http://ci.strongloop.com/job/loopback/975/

@bajtos

bajtos commented Feb 20, 2014

Copy link
Copy Markdown
Member

Excellent! Please squash the commits into a single one and update the commit message to imperative style ("Rewrite test etc." instead of "Rewrites test etc.").

Hint if you are not familiar with interactive rebase: git rebase -i master

@slnode

slnode commented Feb 20, 2014

Copy link
Copy Markdown

Test FAILed. To trigger a build add comment - ".test\W+please"
Refer to this link for build results: http://ci.strongloop.com/job/loopback/976/

bajtos added a commit that referenced this pull request Feb 21, 2014
@bajtos
Merge pull request #195 from globocom/fix-clear-handler-cache-test
fe6ac0b 
Rewrites test for clear handler cache.
@bajtos
bajtos merged commit fe6ac0b into strongloop:master Feb 21, 2014
@bajtos

bajtos commented Feb 21, 2014

Copy link
Copy Markdown
Member

Landed. Thank you for the contribution!

@gcirne

gcirne commented Feb 21, 2014

Copy link
Copy Markdown
Contributor Author

Sure, no problem!

Guilherme Machado Cirne
gcirne@gmail.com

On Fri, Feb 21, 2014 at 2:52 PM, Miroslav Bajtoš
notifications@github.comwrote:

Landed. Thank you for the contribution!

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/195#issuecomment-35755033
.

@gcirne
gcirne deleted the fix-clear-handler-cache-test branch April 9, 2014 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gcirne @slnode @bajtos